diff options
| author | Sagi Grimberg <sagi@grimberg.me> | 2021-01-13 22:56:57 +0100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2021-01-14 20:27:35 +0100 |
| commit | ca1ff67d0fb14f39cf0cc5102b1fbcc3b14f6fb9 (patch) | |
| tree | 6e7c8cea04747d3c8efc190e8eb3175cc7ee894e /drivers/nvme | |
| parent | nvme-tcp: Fix warning with CONFIG_DEBUG_PREEMPT (diff) | |
| download | linux-ca1ff67d0fb14f39cf0cc5102b1fbcc3b14f6fb9.tar.xz linux-ca1ff67d0fb14f39cf0cc5102b1fbcc3b14f6fb9.zip | |
nvme-tcp: fix possible data corruption with bio merges
When a bio merges, we can get a request that spans multiple
bios, and the overall request payload size is the sum of
all bios. When we calculate how much we need to send
from the existing bio (and bvec), we did not take into
account the iov_iter byte count cap.
Since multipage bvecs support, bvecs can split in the middle
which means that when we account for the last bvec send we
should also take the iov_iter byte count cap as it might be
lower than the last bvec size.
Reported-by: Hao Wang <pkuwangh@gmail.com>
Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver")
Tested-by: Hao Wang <pkuwangh@gmail.com>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/tcp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index b2e0865785ef..216619926563 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -201,7 +201,7 @@ static inline size_t nvme_tcp_req_cur_offset(struct nvme_tcp_request *req) static inline size_t nvme_tcp_req_cur_length(struct nvme_tcp_request *req) { - return min_t(size_t, req->iter.bvec->bv_len - req->iter.iov_offset, + return min_t(size_t, iov_iter_single_seg_count(&req->iter), req->pdu_len - req->pdu_sent); } |