summaryrefslogtreecommitdiffstats
path: root/drivers/opp
diff options
context:
space:
mode:
authorAndrew Halaney <ahalaney@redhat.com>2023-06-23 17:53:38 +0200
committerViresh Kumar <viresh.kumar@linaro.org>2023-06-26 08:40:26 +0200
commitfa155f4f834882a79788218aea4914568b41dd0f (patch)
treed242fbc20255176ee1edc7f309fe6a36d4e1002f /drivers/opp
parentOPP: Simplify the over-designed pstate <-> level dance (diff)
downloadlinux-fa155f4f834882a79788218aea4914568b41dd0f.tar.xz
linux-fa155f4f834882a79788218aea4914568b41dd0f.zip
OPP: Use dev_err_probe() when failing to get icc_path
This, in tandem with dynamic debug, can print useful information about -EPROBE_DEFFER like below, and keeps similar behavior for other errors: [ 16.561072] cpu cpu0: error -EPROBE_DEFER: dev_pm_opp_of_find_icc_paths: Unable to get path0 [ 16.575777] platform 18591000.cpufreq: deferred probe pending Signed-off-by: Andrew Halaney <ahalaney@redhat.com> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/opp')
-rw-r--r--drivers/opp/of.c6
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index e6d1155d0990..1f0923cc1cd9 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -513,11 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev,
for (i = 0; i < num_paths; i++) {
paths[i] = of_icc_get_by_index(dev, i);
if (IS_ERR(paths[i])) {
- ret = PTR_ERR(paths[i]);
- if (ret != -EPROBE_DEFER) {
- dev_err(dev, "%s: Unable to get path%d: %d\n",
- __func__, i, ret);
- }
+ ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i);
goto err;
}
}