summaryrefslogtreecommitdiffstats
path: root/drivers/pci
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-07-08 20:05:36 +0200
committerKrzysztof Wilczyński <kwilczynski@kernel.org>2024-07-10 07:38:51 +0200
commit101e5c5c4e766901492b51c33b34af5f775b043f (patch)
tree4dfe9fcdb09b0e288dec8753fb8c8cb5297c2ef7 /drivers/pci
parentPCI: qcom: Add OPP support to scale performance (diff)
downloadlinux-101e5c5c4e766901492b51c33b34af5f775b043f.tar.xz
linux-101e5c5c4e766901492b51c33b34af5f775b043f.zip
PCI: qcom: Fix missing error code in qcom_pcie_probe()
Return a negative error code if dev_pm_opp_find_freq_floor() fails; don't return success. Fixes: 78b5f6f8855e ("PCI: qcom: Add OPP support to scale performance") Link: https://lore.kernel.org/linux-pci/20240708180539.1447307-2-dan.carpenter@linaro.org Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Anders Roxell <anders.roxell@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Diffstat (limited to 'drivers/pci')
-rw-r--r--drivers/pci/controller/dwc/pcie-qcom.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index c8cbfb91e1d5..067ccb9cc6d0 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1578,7 +1578,8 @@ static int qcom_pcie_probe(struct platform_device *pdev)
if (!ret) {
opp = dev_pm_opp_find_freq_floor(dev, &max_freq);
if (IS_ERR(opp)) {
- dev_err_probe(pci->dev, PTR_ERR(opp),
+ ret = PTR_ERR(opp);
+ dev_err_probe(pci->dev, ret,
"Unable to find max freq OPP\n");
goto err_pm_runtime_put;
} else {