summaryrefslogtreecommitdiffstats
path: root/drivers/phy
diff options
context:
space:
mode:
authorKishon Vijay Abraham I <kishon@ti.com>2021-03-19 13:41:25 +0100
committerVinod Koul <vkoul@kernel.org>2021-03-31 13:13:21 +0200
commit29c2d02adbc817e91f078ace1c625c34928bf73a (patch)
tree6dbdd85aff9191c1c951d82211782d6cc91b5f65 /drivers/phy
parentphy: cadence: Sierra: Add array of input clocks in "struct cdns_sierra_phy" (diff)
downloadlinux-29c2d02adbc817e91f078ace1c625c34928bf73a.tar.xz
linux-29c2d02adbc817e91f078ace1c625c34928bf73a.zip
phy: cadence: Sierra: Add missing clk_disable_unprepare() in .remove callback
commit 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Link: https://lore.kernel.org/r/20210319124128.13308-11-kishon@ti.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
-rw-r--r--drivers/phy/cadence/phy-cadence-sierra.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c
index a45278c30948..ac32b7b0289f 100644
--- a/drivers/phy/cadence/phy-cadence-sierra.c
+++ b/drivers/phy/cadence/phy-cadence-sierra.c
@@ -689,6 +689,9 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev)
reset_control_assert(phy->phys[i].lnk_rst);
reset_control_put(phy->phys[i].lnk_rst);
}
+
+ clk_disable_unprepare(phy->input_clks[PHY_CLK]);
+
return 0;
}