diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-07 12:58:54 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-03-20 13:44:58 +0100 |
| commit | b1d9ad66587110fe35f6c2b2cd176c11a400ad24 (patch) | |
| tree | 7deb688c3e192d95f118dce335e53c6452b4b020 /drivers/phy | |
| parent | phy: tegra: xusb: Convert to platform remove callback returning void (diff) | |
| download | linux-b1d9ad66587110fe35f6c2b2cd176c11a400ad24.tar.xz linux-b1d9ad66587110fe35f6c2b2cd176c11a400ad24.zip | |
phy: ti: phy-am654-serdes: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-26-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/ti/phy-am654-serdes.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/phy/ti/phy-am654-serdes.c b/drivers/phy/ti/phy-am654-serdes.c index 0be727bb9f79..4ed2d951d3df 100644 --- a/drivers/phy/ti/phy-am654-serdes.c +++ b/drivers/phy/ti/phy-am654-serdes.c @@ -842,20 +842,18 @@ clk_err: return ret; } -static int serdes_am654_remove(struct platform_device *pdev) +static void serdes_am654_remove(struct platform_device *pdev) { struct serdes_am654 *am654_phy = platform_get_drvdata(pdev); struct device_node *node = am654_phy->of_node; pm_runtime_disable(&pdev->dev); of_clk_del_provider(node); - - return 0; } static struct platform_driver serdes_am654_driver = { .probe = serdes_am654_probe, - .remove = serdes_am654_remove, + .remove_new = serdes_am654_remove, .driver = { .name = "phy-am654", .of_match_table = serdes_am654_id_table, |