diff options
| author | Christian Ruppert <christian.ruppert@abilis.com> | 2014-04-11 16:46:04 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2014-04-22 14:55:02 +0200 |
| commit | 4c5fba3d4ae3a7aae2c4a56d4a234aa556b7caca (patch) | |
| tree | 9e91e1c94fa4e5f5f486edf5a0c61be122112f7a /drivers/pinctrl/pinctrl-tb10x.c | |
| parent | Linux 3.15-rc2 (diff) | |
| download | linux-4c5fba3d4ae3a7aae2c4a56d4a234aa556b7caca.tar.xz linux-4c5fba3d4ae3a7aae2c4a56d4a234aa556b7caca.zip | |
pinctrl/TB10x: Fix signedness bug
In the TB10x pin database, a port index of -1 is used to indicate
unmuxed GPIO pin groups. This bug fixes a 'cast to unsigned' bug of
this value.
Thanks to Dan Carpenter for highlighting this.
CC: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christian Ruppert <christian.ruppert@abilis.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-tb10x.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-tb10x.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c index c5e0f6973a3b..26ca6855f478 100644 --- a/drivers/pinctrl/pinctrl-tb10x.c +++ b/drivers/pinctrl/pinctrl-tb10x.c @@ -629,9 +629,8 @@ static int tb10x_gpio_request_enable(struct pinctrl_dev *pctl, */ for (i = 0; i < state->pinfuncgrpcnt; i++) { const struct tb10x_pinfuncgrp *pfg = &state->pingroups[i]; - unsigned int port = pfg->port; unsigned int mode = pfg->mode; - int j; + int j, port = pfg->port; /* * Skip pin groups which are always mapped and don't need |