diff options
| author | Matthias Fetzer <kontakt@matthias-fetzer.de> | 2024-09-03 19:27:56 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2024-09-04 20:30:31 +0200 |
| commit | 3a1fb526c2482b2f61c9813e9e14fcdab4ffa390 (patch) | |
| tree | 112280cbe655c559f3805a819ef038a930440071 /drivers/platform/x86 | |
| parent | platform/x86: x86-android-tablets: Fix spelling in the comments (diff) | |
| download | linux-3a1fb526c2482b2f61c9813e9e14fcdab4ffa390.tar.xz linux-3a1fb526c2482b2f61c9813e9e14fcdab4ffa390.zip | |
platform/x86: thinkpad_acpi: Fix uninitialized symbol 's' warning
When the TPACPI_FAN_WR_ACPI_FANW branch is taken s stays uninitialized
and would be later used in a debug print.
Since the registers are always set to the same two static values inside the
branch s is initialized to 0.
Fixes: 57d0557dfa49 ("platform/x86: thinkpad_acpi: Add Thinkpad Edge E531 fan support")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/platform-driver-x86/f99e558d-c62a-41eb-93b3-cf00c016d907@stanley.mountain/
Signed-off-by: Matthias Fetzer <kontakt@matthias-fetzer.de>
Link: https://lore.kernel.org/r/20240903172756.19235-1-kontakt@matthias-fetzer.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/x86')
| -rw-r--r-- | drivers/platform/x86/thinkpad_acpi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 8f7053920884..4c1b0553f872 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -8318,7 +8318,7 @@ static int fan_set_level_safe(int level) static int fan_set_enable(void) { - u8 s; + u8 s = 0; int rc; if (!fan_control_allowed) |