diff options
| author | Mika Westerberg <mika.westerberg@linux.intel.com> | 2015-12-09 15:05:59 +0100 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2015-12-16 16:31:27 +0100 |
| commit | c7b91b33cf446ec09eedf4594cff8d7b85ef6870 (patch) | |
| tree | daffc01445932acf103e1cd1cec00df45de82b41 /drivers/pwm | |
| parent | Linux 4.4-rc1 (diff) | |
| download | linux-c7b91b33cf446ec09eedf4594cff8d7b85ef6870.tar.xz linux-c7b91b33cf446ec09eedf4594cff8d7b85ef6870.zip | |
pwm: lpss: Remove ->free() callback
The LPSS PWM driver calls pwm_lpss_disable() when the PWM device is
released (for example unexported from sysfs). This in turn calls
pm_runtime_put() which makes runtime PM count to be unbalanced if the
device has not been enabled at this point.
This is easy to reproduce:
# cd /sys/class/pwm/pwmchip0
# echo 0 > export
# echo 0 > unexport
The count is unbalanced and prevents the PWM device from being powered on
next time.
Fix this by removing ->free() callback. There are no resources to be
released anyway.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/pwm-lpss.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/pwm/pwm-lpss.c b/drivers/pwm/pwm-lpss.c index 25044104003b..3f61c50964d5 100644 --- a/drivers/pwm/pwm-lpss.c +++ b/drivers/pwm/pwm-lpss.c @@ -135,7 +135,6 @@ static void pwm_lpss_disable(struct pwm_chip *chip, struct pwm_device *pwm) } static const struct pwm_ops pwm_lpss_ops = { - .free = pwm_lpss_disable, .config = pwm_lpss_config, .enable = pwm_lpss_enable, .disable = pwm_lpss_disable, |