diff options
| author | Michał Mirosław <mirq-linux@rere.qmqm.pl> | 2020-11-13 01:20:28 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-13 15:21:26 +0100 |
| commit | f5c042b23f7429e5c2ac987b01a31c69059a978b (patch) | |
| tree | 179d31b84013efb26f8d16d3ecd90ea832a853b0 /drivers/regulator | |
| parent | regulator: avoid resolve_supply() infinite recursion (diff) | |
| download | linux-f5c042b23f7429e5c2ac987b01a31c69059a978b.tar.xz linux-f5c042b23f7429e5c2ac987b01a31c69059a978b.zip | |
regulator: workaround self-referent regulators
Workaround regulators whose supply name happens to be the same as its
own name. This fixes boards that used to work before the early supply
resolving was removed. The error message is left in place so that
offending drivers can be detected.
Fixes: aea6cb99703e ("regulator: resolve supply after creating regulator")
Cc: stable@vger.kernel.org
Reported-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de> # stpmic1
Link: https://lore.kernel.org/r/d703acde2a93100c3c7a81059d716c50ad1b1f52.1605226675.git.mirq-linux@rere.qmqm.pl
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/regulator')
| -rw-r--r-- | drivers/regulator/core.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index d3b96efa20fd..42bbd99a36ac 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -1844,7 +1844,10 @@ static int regulator_resolve_supply(struct regulator_dev *rdev) if (r == rdev) { dev_err(dev, "Supply for %s (%s) resolved to itself\n", rdev->desc->name, rdev->supply_name); - return -EINVAL; + if (!have_full_constraints()) + return -EINVAL; + r = dummy_regulator_rdev; + get_device(&r->dev); } /* |