diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-02-20 22:05:29 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2018-03-01 10:49:38 +0100 |
| commit | 1c90d9f1c80ba28ddb61c3dbdc55ac686c073d75 (patch) | |
| tree | 1f18679e3ad5e7a63821e01063c839e8bdcde2f3 /drivers/rtc/rtc-ds1511.c | |
| parent | rtc: tx4939: avoid unintended sign extension on a 24 bit shift (diff) | |
| download | linux-1c90d9f1c80ba28ddb61c3dbdc55ac686c073d75.tar.xz linux-1c90d9f1c80ba28ddb61c3dbdc55ac686c073d75.zip | |
rtc: ds1511: let the core handle invalid time
Returning a valid time when the time is invalid is a bad practice, because
then userspace is not able to react on the information. Also, it doesn't
make sense to return epoch because it is already the default time.
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Diffstat (limited to 'drivers/rtc/rtc-ds1511.c')
| -rw-r--r-- | drivers/rtc/rtc-ds1511.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/rtc/rtc-ds1511.c b/drivers/rtc/rtc-ds1511.c index 5f55214db9f8..a7d5ca428d68 100644 --- a/drivers/rtc/rtc-ds1511.c +++ b/drivers/rtc/rtc-ds1511.c @@ -277,10 +277,6 @@ static int ds1511_rtc_read_time(struct device *dev, struct rtc_time *rtc_tm) rtc_tm->tm_mon--; - if (rtc_valid_tm(rtc_tm) < 0) { - dev_err(dev, "retrieved date/time is not valid.\n"); - rtc_time_to_tm(0, rtc_tm); - } return 0; } |