diff options
| author | Compostella, Jeremy <jeremy.compostella@intel.com> | 2023-06-06 18:13:23 +0200 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-06-12 19:20:45 +0200 |
| commit | 896e97bf99ecf0ecb6cc420bc2c9eb268d3edc05 (patch) | |
| tree | ded77d9cc602dd85d14c000991909db6a96ccc24 /drivers/s390/net/ism_drv.c | |
| parent | Linux 6.4-rc6 (diff) | |
| download | linux-896e97bf99ecf0ecb6cc420bc2c9eb268d3edc05.tar.xz linux-896e97bf99ecf0ecb6cc420bc2c9eb268d3edc05.zip | |
ACPI: EC: Clear GPE on interrupt handling only
On multiple devices I work on, we noticed that
/sys/firmware/acpi/interrupts/sci_not is non-zero and keeps increasing
over time.
It turns out that there is a race condition between servicing a GPE
interrupt and handling task driven transactions.
If a GPE interrupt is received at the same time ec_poll() is running,
the advance_transaction() clears the GPE flag and the interrupt is not
serviced as acpi_ev_detect_gpe() relies on the GPE flag to call the
handler. As a result, `sci_not' is increased.
To address this, move the GPE status check and clearing from
advance_transaction() directly into acpi_ec_handle_interrupt(), so the
EC GPE only gets cleared in the interrupt handling path.
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/s390/net/ism_drv.c')
0 files changed, 0 insertions, 0 deletions