diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2015-12-11 12:27:53 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-12-14 22:16:44 +0100 |
| commit | e043046a5a29bebe7e9a68b92c4580e2888f8ed3 (patch) | |
| tree | 900fadc491e47326cd6e0380a9e88f11e5447c15 /drivers/s390 | |
| parent | MAINTAINERS: switch to alternate IBM mail address (diff) | |
| download | linux-e043046a5a29bebe7e9a68b92c4580e2888f8ed3.tar.xz linux-e043046a5a29bebe7e9a68b92c4580e2888f8ed3.zip | |
s390-ctcm: Delete unnecessary checks before the function call "channel_remove"
The channel_remove() function tests whether its argument is NULL
and then returns immediately. Thus the test around the calls is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390')
| -rw-r--r-- | drivers/s390/net/ctcm_main.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/s390/net/ctcm_main.c b/drivers/s390/net/ctcm_main.c index 05c37d6d4afe..c3e22523faf3 100644 --- a/drivers/s390/net/ctcm_main.c +++ b/drivers/s390/net/ctcm_main.c @@ -1677,11 +1677,8 @@ static int ctcm_shutdown_device(struct ccwgroup_device *cgdev) ccw_device_set_offline(cgdev->cdev[1]); ccw_device_set_offline(cgdev->cdev[0]); - - if (priv->channel[CTCM_READ]) - channel_remove(priv->channel[CTCM_READ]); - if (priv->channel[CTCM_WRITE]) - channel_remove(priv->channel[CTCM_WRITE]); + channel_remove(priv->channel[CTCM_READ]); + channel_remove(priv->channel[CTCM_WRITE]); priv->channel[CTCM_READ] = priv->channel[CTCM_WRITE] = NULL; return 0; |