diff options
| author | Luo Jiaxing <luojiaxing@huawei.com> | 2020-05-15 16:13:43 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-05-20 03:23:58 +0200 |
| commit | 1e954d1f002db802937deb87a868c3f62fe1badf (patch) | |
| tree | 34b7148e227d31974e649bb3a18abbcabed5bf63 /drivers/scsi/hisi_sas | |
| parent | scsi: hisi_sas: Do not reset phy timer to wait for stray phy up (diff) | |
| download | linux-1e954d1f002db802937deb87a868c3f62fe1badf.tar.xz linux-1e954d1f002db802937deb87a868c3f62fe1badf.zip | |
scsi: hisi_sas: Modify the commit information for DSM method
Make it clear that BIOS may modify some register settings.
Link: https://lore.kernel.org/r/1589552025-165012-3-git-send-email-john.garry@huawei.com
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/hisi_sas')
| -rw-r--r-- | drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c index 59b1421607dd..edab8383b485 100644 --- a/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c +++ b/drivers/scsi/hisi_sas/hisi_sas_v3_hw.c @@ -912,11 +912,15 @@ static int hw_init_v3_hw(struct hisi_hba *hisi_hba) return -EINVAL; } - /* Switch over to MSI handling , from PCI AER default */ + /* + * This DSM handles some hardware-related configurations: + * 1. Switch over to MSI error handling in kernel + * 2. BIOS *may* reset some register values through this method + */ obj = acpi_evaluate_dsm(ACPI_HANDLE(dev), &guid, 0, DSM_FUNC_ERR_HANDLE_MSI, NULL); if (!obj) - dev_warn(dev, "Switch over to MSI handling failed\n"); + dev_warn(dev, "can not find DSM method, ignore\n"); else ACPI_FREE(obj); |