summaryrefslogtreecommitdiffstats
path: root/drivers/scsi/isci
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2016-11-18 17:14:01 +0100
committerMartin K. Petersen <martin.petersen@oracle.com>2016-11-29 17:46:08 +0100
commit5cfa2a3c7342bd0b50716c8bb32ee491af43c785 (patch)
tree4298a33ba4f3b2d095a24e2c300a53f13a1a2ac7 /drivers/scsi/isci
parentscsi: hisi_sas: shift vs compare typos (diff)
downloadlinux-5cfa2a3c7342bd0b50716c8bb32ee491af43c785.tar.xz
linux-5cfa2a3c7342bd0b50716c8bb32ee491af43c785.zip
scsi: isci: avoid array subscript warning
I'm getting a new warning with gcc-7: isci/remote_node_context.c: In function 'sci_remote_node_context_destruct': isci/remote_node_context.c:69:16: error: array subscript is above array bounds [-Werror=array-bounds] This is odd, since we clearly cover all values for enum scis_sds_remote_node_context_states here. Anyway, checking for an array overflow can't harm and it makes the warning go away. Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/isci')
-rw-r--r--drivers/scsi/isci/remote_node_context.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/isci/remote_node_context.c b/drivers/scsi/isci/remote_node_context.c
index 30bd80052e03..e3f2a5359d71 100644
--- a/drivers/scsi/isci/remote_node_context.c
+++ b/drivers/scsi/isci/remote_node_context.c
@@ -66,6 +66,9 @@ const char *rnc_state_name(enum scis_sds_remote_node_context_states state)
{
static const char * const strings[] = RNC_STATES;
+ if (state >= ARRAY_SIZE(strings))
+ return "UNKNOWN";
+
return strings[state];
}
#undef C