diff options
| author | Niklas Cassel <niklas.cassel@wdc.com> | 2023-07-31 16:34:18 +0200 |
|---|---|---|
| committer | Damien Le Moal <dlemoal@kernel.org> | 2023-08-02 10:45:30 +0200 |
| commit | 541528170a5cb1342c378dfd46b04dfe024dbc7a (patch) | |
| tree | 3851baa859daff7837141453da457192963c5d23 /drivers/scsi/libsas | |
| parent | ata,scsi: cleanup __ata_port_probe() (diff) | |
| download | linux-541528170a5cb1342c378dfd46b04dfe024dbc7a.tar.xz linux-541528170a5cb1342c378dfd46b04dfe024dbc7a.zip | |
ata,scsi: remove ata_sas_port_init()
ata_sas_port_init() now only contains a single initialization.
Move this single initialization to ata_sas_port_alloc(), since:
1) ata_sas_port_alloc() already initializes some of the struct members.
2) ata_sas_port_alloc() is only used by libsas.
Suggested-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Diffstat (limited to 'drivers/scsi/libsas')
| -rw-r--r-- | drivers/scsi/libsas/sas_ata.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index d6bb37b3974a..cd16a1ac379d 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -605,9 +605,6 @@ int sas_ata_init(struct domain_device *found_dev) ap->private_data = found_dev; ap->cbl = ATA_CBL_SATA; ap->scsi_host = shost; - rc = ata_sas_port_init(ap); - if (rc) - goto destroy_port; rc = ata_sas_tport_add(ata_host->dev, ap); if (rc) |