diff options
author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-06-14 17:29:21 +0200 |
---|---|---|
committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2023-06-15 18:05:19 +0200 |
commit | 22db06337f590d01d79f60f181d8dfe5a9ef9085 (patch) | |
tree | 7813cfc4fb4a23cae97949be8144b32d49b38198 /drivers/scsi/lpfc/lpfc_bsg.c | |
parent | Linux 6.4-rc6 (diff) | |
download | linux-22db06337f590d01d79f60f181d8dfe5a9ef9085.tar.xz linux-22db06337f590d01d79f60f181d8dfe5a9ef9085.zip |
ACPI: sleep: Avoid breaking S3 wakeup due to might_sleep()
The addition of might_sleep() to down_timeout() caused the latter to
enable interrupts unconditionally in some cases, which in turn broke
the ACPI S3 wakeup path in acpi_suspend_enter(), where down_timeout()
is called by acpi_disable_all_gpes() via acpi_ut_acquire_mutex().
Namely, if CONFIG_DEBUG_ATOMIC_SLEEP is set, might_sleep() causes
might_resched() to be used and if CONFIG_PREEMPT_VOLUNTARY is set,
this triggers __cond_resched() which may call preempt_schedule_common(),
so __schedule() gets invoked and it ends up with enabled interrupts (in
the prev == next case).
Now, enabling interrupts early in the S3 wakeup path causes the kernel
to crash.
Address this by modifying acpi_suspend_enter() to disable GPEs without
attempting to acquire the sleeping lock which is not needed in that code
path anyway.
Fixes: 99409b935c9a ("locking/semaphore: Add might_sleep() to down_*() family")
Reported-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: 5.15+ <stable@vger.kernel.org> # 5.15+
Diffstat (limited to 'drivers/scsi/lpfc/lpfc_bsg.c')
0 files changed, 0 insertions, 0 deletions