diff options
| author | Sagi Grimberg <sagig@mellanox.com> | 2015-06-25 12:34:15 +0200 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2015-07-14 19:20:09 +0200 |
| commit | 3fdf70acec13efc7ecf254f5a364df06348bfd2c (patch) | |
| tree | 9c463c5431b02863acc8a4af9ed02796b01aa232 /drivers/scsi/scsi_transport_srp.c | |
| parent | IB/srpt: Convert use of __constant_cpu_to_beXX to cpu_to_beXX (diff) | |
| download | linux-3fdf70acec13efc7ecf254f5a364df06348bfd2c.tar.xz linux-3fdf70acec13efc7ecf254f5a364df06348bfd2c.zip | |
IB/srp: Avoid using uninitialized variable
We might return res which is not initialized. Also
reduce code duplication by exporting srp_parse_tmo so
srp_tmo_set can reuse it.
Detected by Coverity.
Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
Signed-off-by: Jenny Falkovich <jennyf@mellanox.com>
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
Diffstat (limited to 'drivers/scsi/scsi_transport_srp.c')
| -rw-r--r-- | drivers/scsi/scsi_transport_srp.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c index a85292b1d09d..e3cd3ece4412 100644 --- a/drivers/scsi/scsi_transport_srp.c +++ b/drivers/scsi/scsi_transport_srp.c @@ -203,7 +203,7 @@ static ssize_t srp_show_tmo(char *buf, int tmo) return tmo >= 0 ? sprintf(buf, "%d\n", tmo) : sprintf(buf, "off\n"); } -static int srp_parse_tmo(int *tmo, const char *buf) +int srp_parse_tmo(int *tmo, const char *buf) { int res = 0; @@ -214,6 +214,7 @@ static int srp_parse_tmo(int *tmo, const char *buf) return res; } +EXPORT_SYMBOL(srp_parse_tmo); static ssize_t show_reconnect_delay(struct device *dev, struct device_attribute *attr, char *buf) |