summaryrefslogtreecommitdiffstats
path: root/drivers/scsi
diff options
context:
space:
mode:
authorZhongqiu Han <quic_zhonhan@quicinc.com>2024-07-05 12:36:14 +0200
committerMartin K. Petersen <martin.petersen@oracle.com>2024-07-11 04:51:44 +0200
commit23cef42d17413d099f44ea42b622fbf23b04646f (patch)
tree6228765f20c447218f0903b250cd48e7705095f6 /drivers/scsi
parentscsi: qla2xxx: Convert comma to semicolon (diff)
downloadlinux-23cef42d17413d099f44ea42b622fbf23b04646f.tar.xz
linux-23cef42d17413d099f44ea42b622fbf23b04646f.zip
scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant completion
The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. See also commit 6e9a4738c9fa ("[PATCH] completions: lockdep annotate on stack completions"). Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com> Link: https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/aha152x.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index 83f16fc14d96..a0fb330b8df5 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt)
static int aha152x_device_reset(struct scsi_cmnd * SCpnt)
{
struct Scsi_Host *shpnt = SCpnt->device->host;
- DECLARE_COMPLETION(done);
+ DECLARE_COMPLETION_ONSTACK(done);
int ret, issued, disconnected;
unsigned char old_cmd_len = SCpnt->cmd_len;
unsigned long flags;