diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2019-07-10 13:42:43 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-07-22 14:19:40 +0200 |
| commit | 3da9834d9381dd99273f2ad4e6d096c9187dc4f2 (patch) | |
| tree | 770e956c414837a3d1d68d00df5b4286bbc25989 /drivers/spi/spi-dw-mmio.c | |
| parent | spi: dw-mmio: Use devm_platform_ioremap_resource() (diff) | |
| download | linux-3da9834d9381dd99273f2ad4e6d096c9187dc4f2.tar.xz linux-3da9834d9381dd99273f2ad4e6d096c9187dc4f2.zip | |
spi: dw-mmio: Clock should be shut when error occurs
When optional clock requesting fails, the main clock is still up and running,
we should shut it down in such caee.
Fixes: 560ee7e91009 ("spi: dw: Add support for an optional interface clock")
Cc: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Gareth Williams <gareth.williams.jx@renesas.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Gareth Williams <gareth.williams.jx@renesas.com>
Link: https://lore.kernel.org/r/20190710114243.30101-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-dw-mmio.c')
| -rw-r--r-- | drivers/spi/spi-dw-mmio.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/spi/spi-dw-mmio.c b/drivers/spi/spi-dw-mmio.c index 1c1cac92a9de..4fa7e7a52ebd 100644 --- a/drivers/spi/spi-dw-mmio.c +++ b/drivers/spi/spi-dw-mmio.c @@ -170,8 +170,10 @@ static int dw_spi_mmio_probe(struct platform_device *pdev) /* Optional clock needed to access the registers */ dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk"); - if (IS_ERR(dwsmmio->pclk)) - return PTR_ERR(dwsmmio->pclk); + if (IS_ERR(dwsmmio->pclk)) { + ret = PTR_ERR(dwsmmio->pclk); + goto out_clk; + } ret = clk_prepare_enable(dwsmmio->pclk); if (ret) goto out_clk; |