diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2021-04-20 21:46:13 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-04-21 17:07:04 +0200 |
| commit | 24b5515aa3ac075880be776bf36553ff7f9712c7 (patch) | |
| tree | c543237189edeb9e2e0204c9870f11920bfb562e /drivers/spi/spi-fsi.c | |
| parent | spi: Make error handling of gpiod_count() call cleaner (diff) | |
| download | linux-24b5515aa3ac075880be776bf36553ff7f9712c7.tar.xz linux-24b5515aa3ac075880be776bf36553ff7f9712c7.zip | |
spi: fsi: add a missing of_node_put
'for_each_available_child_of_node' performs an of_node_get on each
iteration, so a return from the middle of the loop requires an of_node_put.
Fixes: bbb6b2f9865b ("spi: Add FSI-attached SPI controller driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/504e431b900341249d331b868d90312cf41f415a.1618947919.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-fsi.c')
| -rw-r--r-- | drivers/spi/spi-fsi.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c index de359718e816..87f8829c3995 100644 --- a/drivers/spi/spi-fsi.c +++ b/drivers/spi/spi-fsi.c @@ -566,8 +566,10 @@ static int fsi_spi_probe(struct device *dev) continue; ctlr = spi_alloc_master(dev, sizeof(*ctx)); - if (!ctlr) + if (!ctlr) { + of_node_put(np); break; + } ctlr->dev.of_node = np; ctlr->num_chipselect = of_get_available_child_count(np) ?: 1; |