summaryrefslogtreecommitdiffstats
path: root/drivers/spi/spi-pic32.c
diff options
context:
space:
mode:
authorAlexey Khoroshilov <khoroshilov@ispras.ru>2018-09-07 00:16:54 +0200
committerMark Brown <broonie@kernel.org>2018-09-07 18:04:51 +0200
commitb9a947dd756b7af84ababa57e0524788f91a5382 (patch)
tree7d83a32c9d56c8804da8918e91bcdda63b54fda5 /drivers/spi/spi-pic32.c
parentspi: pl022: Remove set but not used variable 'chip' (diff)
downloadlinux-b9a947dd756b7af84ababa57e0524788f91a5382.tar.xz
linux-b9a947dd756b7af84ababa57e0524788f91a5382.zip
spi: pic32: remove unnecessary of_node_get()
Almost all spi drivers assign spi master->dev.of_node from its parent platform device without additional refcounting. It seems of_node_get() in pic32_spi_probe() is unnecessary and there is no corresponding of_node_put(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-pic32.c')
-rw-r--r--drivers/spi/spi-pic32.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-pic32.c b/drivers/spi/spi-pic32.c
index f8a45af1fa9f..46ff76193ee1 100644
--- a/drivers/spi/spi-pic32.c
+++ b/drivers/spi/spi-pic32.c
@@ -774,7 +774,7 @@ static int pic32_spi_probe(struct platform_device *pdev)
if (ret)
goto err_master;
- master->dev.of_node = of_node_get(pdev->dev.of_node);
+ master->dev.of_node = pdev->dev.of_node;
master->mode_bits = SPI_MODE_3 | SPI_MODE_0 | SPI_CS_HIGH;
master->num_chipselect = 1; /* single chip-select */
master->max_speed_hz = clk_get_rate(pic32s->clk);