summaryrefslogtreecommitdiffstats
path: root/drivers/staging
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2017-05-28 14:31:48 +0200
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-06-07 17:47:17 +0200
commit797f91e6417abcc9a07f9c99dd9128ae7622ee81 (patch)
tree66dfcfeaf5c3e0aafa52d6c8ff263d8c2967d13b /drivers/staging
parent[media] staging: atomisp: Fix calling efivar_entry_get() with unaligned argum... (diff)
downloadlinux-797f91e6417abcc9a07f9c99dd9128ae7622ee81.tar.xz
linux-797f91e6417abcc9a07f9c99dd9128ae7622ee81.zip
[media] staging: atomisp: Do not call dev_warn with a NULL device
Do not call dev_warn with a NULL device, this silence the following 2 warnings: [ 14.392194] (NULL device *): Failed to find gmin variable gmin_V2P8GPIO [ 14.392257] (NULL device *): Failed to find gmin variable gmin_V1P8GPIO We could switch to using pr_warn for dev == NULL instead, but as comments in the source indicate, the check for these 2 special gmin variables with a NULL device is a workaround for 2 specific evaluation boards, so completely silencing the missing warning for these actually is a good thing. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Diffstat (limited to 'drivers/staging')
-rw-r--r--drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
index fe996d0cb71c..edaae93af8f9 100644
--- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c
@@ -704,7 +704,7 @@ int gmin_get_config_var(struct device *dev, const char *var, char *out,
if (ret == 0) {
memcpy(out, ev->var.Data, ev->var.DataSize);
*out_len = ev->var.DataSize;
- } else {
+ } else if (dev) {
dev_warn(dev, "Failed to find gmin variable %s\n", var8);
}