diff options
| author | Mike Christie <mchristi@redhat.com> | 2018-07-23 21:07:43 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2018-07-31 05:17:53 +0200 |
| commit | f0e89aae609bebd430ce7a96d2f642917d89ca57 (patch) | |
| tree | b526b338a5969cbd82c3e57de7d772aafd88f641 /drivers/target/target_core_user.c | |
| parent | scsi: libiscsi: Annotate fall-through (diff) | |
| download | linux-f0e89aae609bebd430ce7a96d2f642917d89ca57.tar.xz linux-f0e89aae609bebd430ce7a96d2f642917d89ca57.zip | |
scsi: target_core_user: fix double unlock
The caller of queue_cmd_ring grabs and releases the lock, so the
tcmu_setup_cmd_timer failure handling inside queue_cmd_ring should not call
mutex_unlock.
Signed-off-by: Mike Christie <mchristi@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target/target_core_user.c')
| -rw-r--r-- | drivers/target/target_core_user.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index 847707a700cf..fafe65fd37f4 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1066,7 +1066,6 @@ static sense_reason_t queue_cmd_ring(struct tcmu_cmd *tcmu_cmd, int *scsi_err) &udev->cmd_timer); if (ret) { tcmu_cmd_free_data(tcmu_cmd, tcmu_cmd->dbi_cnt); - mutex_unlock(&udev->cmdr_lock); *scsi_err = TCM_OUT_OF_RESOURCES; return -1; |