diff options
| author | Dmitry Bogdanov <d.bogdanov@yadro.com> | 2022-09-09 11:04:23 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2022-10-01 11:03:57 +0200 |
| commit | f050a7c66ca56aa2f49ab9b53e01d04b3e7e94c5 (patch) | |
| tree | 0b1a1b61ad0160a5a7b854214b083a110f849a05 /drivers/target | |
| parent | scsi: target: core: Fix preempt and abort for allreg res (diff) | |
| download | linux-f050a7c66ca56aa2f49ab9b53e01d04b3e7e94c5.tar.xz linux-f050a7c66ca56aa2f49ab9b53e01d04b3e7e94c5.zip | |
scsi: target: core: Fix memory leak in preempt_and_abort
Always release preempt_and_abort_list to avoid memory leak of
t10_pr_registration objects in it.
Link: https://lore.kernel.org/r/20220909090425.14479-3-d.bogdanov@yadro.com
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_pr.c | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/drivers/target/target_core_pr.c b/drivers/target/target_core_pr.c index 1521a97ddac2..e3869576f254 100644 --- a/drivers/target/target_core_pr.c +++ b/drivers/target/target_core_pr.c @@ -2956,13 +2956,14 @@ core_scsi3_pro_preempt(struct se_cmd *cmd, int type, int scope, u64 res_key, __core_scsi3_complete_pro_preempt(dev, pr_reg_n, (preempt_type == PREEMPT_AND_ABORT) ? &preempt_and_abort_list : NULL, type, scope, preempt_type); - - if (preempt_type == PREEMPT_AND_ABORT) - core_scsi3_release_preempt_and_abort( - &preempt_and_abort_list, pr_reg_n); } + spin_unlock(&dev->dev_reservation_lock); + if (preempt_type == PREEMPT_AND_ABORT) + core_scsi3_release_preempt_and_abort( + &preempt_and_abort_list, pr_reg_n); + if (pr_tmpl->pr_aptpl_active) core_scsi3_update_and_write_aptpl(cmd->se_dev, true); |