diff options
| author | Daniel Lezcano <daniel.lezcano@linaro.org> | 2017-10-19 19:05:48 +0200 |
|---|---|---|
| committer | Eduardo Valentin <edubezval@gmail.com> | 2017-11-01 03:32:15 +0100 |
| commit | 2d4fa7b4c6f8080ced2e8237c9f46fb1fc110d64 (patch) | |
| tree | ff47abcac525a4ca4f81e511ff35fd0013bc9fbe /drivers/thermal/hisi_thermal.c | |
| parent | thermal/drivers/hisi: Fix multiple alarm interrupts firing (diff) | |
| download | linux-2d4fa7b4c6f8080ced2e8237c9f46fb1fc110d64.tar.xz linux-2d4fa7b4c6f8080ced2e8237c9f46fb1fc110d64.zip | |
thermal/drivers/hisi: Remove pointless lock
The threaded interrupt inspect the sensors structure to look in the temp
threshold field, but this field is read-only in all the code, except in the
probe function before the threaded interrupt is set. In other words there
is not race window in the threaded interrupt when reading the field value.
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers/thermal/hisi_thermal.c')
| -rw-r--r-- | drivers/thermal/hisi_thermal.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/thermal/hisi_thermal.c b/drivers/thermal/hisi_thermal.c index f5231974504c..9ec5f290b850 100644 --- a/drivers/thermal/hisi_thermal.c +++ b/drivers/thermal/hisi_thermal.c @@ -221,14 +221,10 @@ static irqreturn_t hisi_thermal_alarm_irq(int irq, void *dev) static irqreturn_t hisi_thermal_alarm_irq_thread(int irq, void *dev) { struct hisi_thermal_data *data = dev; - struct hisi_thermal_sensor *sensor; - - mutex_lock(&data->thermal_lock); - sensor = &data->sensors; + struct hisi_thermal_sensor *sensor = &data->sensors; dev_crit(&data->pdev->dev, "THERMAL ALARM: T > %d\n", sensor->thres_temp); - mutex_unlock(&data->thermal_lock); thermal_zone_device_update(data->sensors.tzd, THERMAL_EVENT_UNSPECIFIED); |