summaryrefslogtreecommitdiffstats
path: root/drivers/tty
diff options
context:
space:
mode:
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>2024-03-01 22:45:29 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-03-02 22:06:22 +0100
commit38f3fc2e82a03d6dbb30c1fecacc630bd0ac9c28 (patch)
treec8860aa06a66ea82cc0c2e8caea0842f81b6f65e /drivers/tty
parentserial: pch: Don't disable interrupts while acquiring lock in ISR. (diff)
downloadlinux-38f3fc2e82a03d6dbb30c1fecacc630bd0ac9c28.tar.xz
linux-38f3fc2e82a03d6dbb30c1fecacc630bd0ac9c28.zip
serial: pch: Don't initialize uart_port's spin_lock.
There is no need to directly initialize the spinlock_t in struct uart_port. The structure is later passed to uart_add_one_port() which initialize the complete struct including the lock member. Remove spin_lock_init() on uart_port's internal lock. Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Link: https://lore.kernel.org/r/20240301215246.891055-17-bigeasy@linutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
-rw-r--r--drivers/tty/serial/pch_uart.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c
index 6e259f413915..391170391876 100644
--- a/drivers/tty/serial/pch_uart.c
+++ b/drivers/tty/serial/pch_uart.c
@@ -1725,8 +1725,6 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev,
KBUILD_MODNAME ":" PCH_UART_DRIVER_DEVICE "%d",
priv->port.line);
- spin_lock_init(&priv->port.lock);
-
pci_set_drvdata(pdev, priv);
priv->trigger_level = 1;
priv->fcr = 0;