diff options
| author | Andrzej Pietrasiewicz <andrzej.p@samsung.com> | 2014-05-15 13:43:50 +0200 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2014-05-15 17:30:31 +0200 |
| commit | 1ade5d7e179170e3cf4780ba578ebb8cc7aa15ef (patch) | |
| tree | 547b295da1c84b8afeb96753d6274ce8c5d83c17 /drivers/usb | |
| parent | usb: dwc3: convert to pcim_enable_device() (diff) | |
| download | linux-1ade5d7e179170e3cf4780ba578ebb8cc7aa15ef.tar.xz linux-1ade5d7e179170e3cf4780ba578ebb8cc7aa15ef.zip | |
usb: gadget: f_uac2: don't queue new requests when shutting down
In some circumstances when g_audio is being unloaded there happens
an endless loop in udc driver. It has happend on a board with
s3c-hsotg. If there are requests in endpoint's queue, they are completed
in a loop. But completing them might cause appending new requests
to the queue. This patch causes agdev_iso_complete() to return immediately
if request's status is -ESHUTDOWN. If it does not return immediately,
then although the current request is removed from the queue, a new one
is appended to the queue, so the above mentioned loop cannot end.
Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/gadget/f_uac2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/gadget/f_uac2.c b/drivers/usb/gadget/f_uac2.c index c024d27fcce2..6261db4a9910 100644 --- a/drivers/usb/gadget/f_uac2.c +++ b/drivers/usb/gadget/f_uac2.c @@ -196,7 +196,7 @@ agdev_iso_complete(struct usb_ep *ep, struct usb_request *req) struct snd_uac2_chip *uac2 = prm->uac2; /* i/f shutting down */ - if (!prm->ep_enabled) + if (!prm->ep_enabled || req->status == -ESHUTDOWN) return; /* |