diff options
| author | Yan Zhao <yan.y.zhao@intel.com> | 2020-09-16 04:30:05 +0200 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2020-09-22 18:56:41 +0200 |
| commit | 2c5af98592f65517170c7bcc714566590d3f7397 (patch) | |
| tree | 0b1855ea746a7931f2c17f2d3645d5039b89a5d9 /drivers/vfio | |
| parent | vfio: fix a missed vfio group put in vfio_pin_pages (diff) | |
| download | linux-2c5af98592f65517170c7bcc714566590d3f7397.tar.xz linux-2c5af98592f65517170c7bcc714566590d3f7397.zip | |
vfio/type1: fix dirty bitmap calculation in vfio_dma_rw
The count of dirtied pages is not only determined by count of copied
pages, but also by the start offset.
e.g. if offset = PAGE_SIZE - 1, and *copied=2, the dirty pages count
is 2, instead of 1 or 0.
Fixes: d6a4c185660c ("vfio iommu: Implementation of ioctl for dirty pages tracking")
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
| -rw-r--r-- | drivers/vfio/vfio_iommu_type1.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 5fbf0c1f7433..d0438388feeb 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -2933,7 +2933,8 @@ static int vfio_iommu_type1_dma_rw_chunk(struct vfio_iommu *iommu, * size */ bitmap_set(dma->bitmap, offset >> pgshift, - *copied >> pgshift); + ((offset + *copied - 1) >> pgshift) - + (offset >> pgshift) + 1); } } else *copied = copy_from_user(data, (void __user *)vaddr, |