diff options
| author | Thomas Zimmermann <tzimmermann@suse.de> | 2023-09-27 09:26:43 +0200 |
|---|---|---|
| committer | Thomas Zimmermann <tzimmermann@suse.de> | 2023-10-19 12:54:56 +0200 |
| commit | d47f9775c1a6d3200d99ff8e7ea90c81af502c96 (patch) | |
| tree | 329b9ee8979ffb5f8ea1721985cd16b494939da1 /drivers/video/fbdev/cobalt_lcdfb.c | |
| parent | fbdev/cirrusfb: Initialize fb_ops to fbdev I/O-memory helpers (diff) | |
| download | linux-d47f9775c1a6d3200d99ff8e7ea90c81af502c96.tar.xz linux-d47f9775c1a6d3200d99ff8e7ea90c81af502c96.zip | |
fbdev/cobalt-lcd: Initialize fb_ops to fbdev I/O-memory helpers
Initialize the instance of struct fb_ops with fbdev initializer
macros for framebuffers in I/O address space. Set the read/write,
draw and mmap callbacks to the correct implementation and avoid
implicit defaults. Also select the necessary I/O helpers in Kconfig.
Fbdev drivers sometimes rely on the callbacks being NULL for a
default implementation to be invoked; hence requiring the I/O
helpers to be built in any case. Setting all callbacks in all
drivers explicitly will allow to make the I/O helpers optional.
This benefits systems that do not use these functions.
No functional changes.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230927074722.6197-11-tzimmermann@suse.de
Diffstat (limited to 'drivers/video/fbdev/cobalt_lcdfb.c')
| -rw-r--r-- | drivers/video/fbdev/cobalt_lcdfb.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/fbdev/cobalt_lcdfb.c b/drivers/video/fbdev/cobalt_lcdfb.c index b94e7c97264c..c2b8f894799c 100644 --- a/drivers/video/fbdev/cobalt_lcdfb.c +++ b/drivers/video/fbdev/cobalt_lcdfb.c @@ -280,7 +280,9 @@ static const struct fb_ops cobalt_lcd_fbops = { .fb_read = cobalt_lcdfb_read, .fb_write = cobalt_lcdfb_write, .fb_blank = cobalt_lcdfb_blank, + __FB_DEFAULT_IOMEM_OPS_DRAW, .fb_cursor = cobalt_lcdfb_cursor, + __FB_DEFAULT_IOMEM_OPS_MMAP, }; static int cobalt_lcdfb_probe(struct platform_device *dev) |