diff options
| author | Wei Chen <harperchen1110@gmail.com> | 2023-03-15 08:18:31 +0100 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2023-03-16 16:18:16 +0100 |
| commit | 92e2a00f2987483e1f9253625828622edd442e61 (patch) | |
| tree | 6971a1c426ed3bb0ed763873a7fe2c6df0274dc6 /drivers/video/fbdev | |
| parent | fbdev: stifb: Provide valid pixelclock and add fb_check_var() checks (diff) | |
| download | linux-92e2a00f2987483e1f9253625828622edd442e61.tar.xz linux-92e2a00f2987483e1f9253625828622edd442e61.zip | |
fbdev: nvidia: Fix potential divide by zero
variable var->pixclock can be set by user. In case it
equals to zero, divide by zero would occur in nvidiafb_set_par.
Similar crashes have happened in other fbdev drivers. There
is no check and modification on var->pixclock along the call
chain to nvidia_check_var and nvidiafb_set_par. We believe it
could also be triggered in driver nvidia from user site.
Signed-off-by: Wei Chen <harperchen1110@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video/fbdev')
| -rw-r--r-- | drivers/video/fbdev/nvidia/nvidia.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/video/fbdev/nvidia/nvidia.c b/drivers/video/fbdev/nvidia/nvidia.c index e60a276b4855..ea4ba3dfb96b 100644 --- a/drivers/video/fbdev/nvidia/nvidia.c +++ b/drivers/video/fbdev/nvidia/nvidia.c @@ -764,6 +764,8 @@ static int nvidiafb_check_var(struct fb_var_screeninfo *var, int pitch, err = 0; NVTRACE_ENTER(); + if (!var->pixclock) + return -EINVAL; var->transp.offset = 0; var->transp.length = 0; |