summaryrefslogtreecommitdiffstats
path: root/drivers/xen/swiotlb-xen.c
diff options
context:
space:
mode:
authorJan Beulich <jbeulich@suse.com>2021-09-07 14:04:25 +0200
committerJuergen Gross <jgross@suse.com>2021-09-15 08:42:04 +0200
commitce6a80d1b2f923b1839655a1cda786293feaa085 (patch)
treea021d2ff413df93a31f6296dcdefaa0f05dfb506 /drivers/xen/swiotlb-xen.c
parentxen/pvcalls: backend can be a module (diff)
downloadlinux-ce6a80d1b2f923b1839655a1cda786293feaa085.tar.xz
linux-ce6a80d1b2f923b1839655a1cda786293feaa085.zip
swiotlb-xen: avoid double free
Of the two paths leading to the "error" label in xen_swiotlb_init() one didn't allocate anything, while the other did already free what was allocated. Fixes: b82776005369 ("xen/swiotlb: Use the swiotlb_late_init_with_tbl to init Xen-SWIOTLB late when PV PCI is used") Signed-off-by: Jan Beulich <jbeulich@suse.com> Cc: stable@vger.kernel.org Reviewed-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/ce9c2adb-8a52-6293-982a-0d6ece943ac6@suse.com Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to 'drivers/xen/swiotlb-xen.c')
-rw-r--r--drivers/xen/swiotlb-xen.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index 24d11861ac7d..99d518526eaf 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -216,7 +216,6 @@ error:
goto retry;
}
pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc);
- free_pages((unsigned long)start, order);
return rc;
}