diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2018-10-12 09:20:16 +0200 |
|---|---|---|
| committer | Eduardo Valentin <edubezval@gmail.com> | 2018-10-25 19:44:55 +0200 |
| commit | 697ee786f15d7b65c7f3045d45fe3a05d28e0911 (patch) | |
| tree | 5abc75235b15ac49fffdc88b2571f28ab6e230f7 /drivers | |
| parent | thermal: rcar_thermal: Prevent hardware access during system suspend (diff) | |
| download | linux-697ee786f15d7b65c7f3045d45fe3a05d28e0911.tar.xz linux-697ee786f15d7b65c7f3045d45fe3a05d28e0911.zip | |
thermal: rcar_thermal: Prevent doing work after unbind
When testing bind/unbind on r8a7791/koelsch:
WARNING: CPU: 1 PID: 697 at lib/debugobjects.c:329 debug_print_object+0x8c/0xb4
ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x10
This happens if the workqueue runs after the device has been unbound.
Fix this by cancelling any queued work during remove.
Fixes: e0a5172e9eec7f0d ("thermal: rcar: add interrupt support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/thermal/rcar_thermal.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c index f0e385dd7a92..6d3205819da3 100644 --- a/drivers/thermal/rcar_thermal.c +++ b/drivers/thermal/rcar_thermal.c @@ -469,6 +469,7 @@ static int rcar_thermal_remove(struct platform_device *pdev) rcar_thermal_for_each_priv(priv, common) { rcar_thermal_irq_disable(priv); + cancel_delayed_work_sync(&priv->work); if (priv->chip->use_of_thermal) thermal_remove_hwmon_sysfs(priv->zone); else |