diff options
| author | Johan Hovold <johan@kernel.org> | 2019-10-10 14:58:35 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-10-15 20:07:43 +0200 |
| commit | b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2 (patch) | |
| tree | 6d3a61a0a6e5c3c017d8d1c5e406ce34bd428bc9 /drivers | |
| parent | USB: ldusb: fix memleak on disconnect (diff) | |
| download | linux-b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2.tar.xz linux-b6c03e5f7b463efcafd1ce141bd5a8fc4e583ae2.zip | |
USB: legousbtower: fix memleak on disconnect
If disconnect() races with release() after a process has been
interrupted, release() could end up returning early and the driver would
fail to free its driver data.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191010125835.27031-3-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/misc/legousbtower.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index 9d4c52a7ebe0..62dab2441ec4 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -419,10 +419,7 @@ static int tower_release (struct inode *inode, struct file *file) goto exit; } - if (mutex_lock_interruptible(&dev->lock)) { - retval = -ERESTARTSYS; - goto exit; - } + mutex_lock(&dev->lock); if (dev->open_count != 1) { dev_dbg(&dev->udev->dev, "%s: device not opened exactly once\n", |