diff options
| author | David Howells <dhowells@redhat.com> | 2019-05-09 17:17:05 +0200 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2019-05-16 17:25:21 +0200 |
| commit | 87182759cd6f94875d6aaaac74eaa52aa6aa6f98 (patch) | |
| tree | 3a143ae4a411fd26b1d98bffff3f66770e027901 /fs/afs/internal.h | |
| parent | afs: Get rid of afs_call::reply[] (diff) | |
| download | linux-87182759cd6f94875d6aaaac74eaa52aa6aa6f98.tar.xz linux-87182759cd6f94875d6aaaac74eaa52aa6aa6f98.zip | |
afs: Fix order-1 allocation in afs_do_lookup()
afs_do_lookup() will do an order-1 allocation to allocate status records if
there are more than 39 vnodes to stat.
Fix this by allocating an array of {status,callback} records for each vnode
we want to examine using vmalloc() if larger than a page.
This not only gets rid of the order-1 allocation, but makes it easier to
grow beyond 50 records for YFS servers. It also allows us to move to
{status,callback} tuples for other calls too and makes it easier to lock
across the application of the status and the callback to the vnode.
Fixes: 5cf9dd55a0ec ("afs: Prospectively look up extra files when doing a single lookup")
Signed-off-by: David Howells <dhowells@redhat.com>
Diffstat (limited to 'fs/afs/internal.h')
| -rw-r--r-- | fs/afs/internal.h | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/fs/afs/internal.h b/fs/afs/internal.h index 705833eb2d45..2a100be91721 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h @@ -137,6 +137,7 @@ struct afs_call { struct afs_file_status *out_vnode_status; struct afs_file_status *out_extra_status; struct afs_callback *out_cb; + struct afs_status_cb *out_scb; struct yfs_acl *out_yacl; struct afs_volsync *out_volsync; struct afs_volume_status *out_volstatus; @@ -991,9 +992,8 @@ extern struct afs_call *afs_fs_get_capabilities(struct afs_net *, struct afs_ser struct afs_addr_cursor *, struct key *, unsigned int); extern int afs_fs_inline_bulk_status(struct afs_fs_cursor *, struct afs_net *, - struct afs_fid *, struct afs_file_status *, - struct afs_callback *, unsigned int, - struct afs_volsync *); + struct afs_fid *, struct afs_status_cb *, + unsigned int, struct afs_volsync *); extern int afs_fs_fetch_status(struct afs_fs_cursor *, struct afs_net *, struct afs_fid *, struct afs_file_status *, struct afs_callback *, struct afs_volsync *); @@ -1393,9 +1393,8 @@ extern int yfs_fs_fetch_status(struct afs_fs_cursor *, struct afs_net *, struct afs_fid *, struct afs_file_status *, struct afs_callback *, struct afs_volsync *); extern int yfs_fs_inline_bulk_status(struct afs_fs_cursor *, struct afs_net *, - struct afs_fid *, struct afs_file_status *, - struct afs_callback *, unsigned int, - struct afs_volsync *); + struct afs_fid *, struct afs_status_cb *, + unsigned int, struct afs_volsync *); struct yfs_acl { struct afs_acl *acl; /* Dir/file/symlink ACL */ |