diff options
| author | Filipe Manana <fdmanana@suse.com> | 2019-09-11 18:42:28 +0200 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2019-09-24 14:45:23 +0200 |
| commit | 0607eb1d452d45c5ac4c745a9e9e0d95152ea9d0 (patch) | |
| tree | 14edea7563fc48d25346c4e4199ddc4e600aa9f5 /fs/btrfs | |
| parent | btrfs: adjust dirty_metadata_bytes after writeback failure of extent buffer (diff) | |
| download | linux-0607eb1d452d45c5ac4c745a9e9e0d95152ea9d0.tar.xz linux-0607eb1d452d45c5ac4c745a9e9e0d95152ea9d0.zip | |
Btrfs: fix missing error return if writeback for extent buffer never started
If lock_extent_buffer_for_io() fails, it returns a negative value, but its
caller btree_write_cache_pages() ignores such error. This means that a
call to flush_write_bio(), from lock_extent_buffer_for_io(), might have
failed. We should make btree_write_cache_pages() notice such error values
and stop immediatelly, making sure filemap_fdatawrite_range() returns an
error to the transaction commit path. A failure from flush_write_bio()
should also result in the endio callback end_bio_extent_buffer_writepage()
being invoked, which sets the BTRFS_FS_*_ERR bits appropriately, so that
there's no risk a transaction or log commit doesn't catch a writeback
failure.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/extent_io.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index 67066ece4de3..380ced84d4b1 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -3978,6 +3978,10 @@ retry: if (!ret) { free_extent_buffer(eb); continue; + } else if (ret < 0) { + done = 1; + free_extent_buffer(eb); + break; } ret = write_one_eb(eb, wbc, &epd); |