summaryrefslogtreecommitdiffstats
path: root/fs/cifs/fs_context.c
diff options
context:
space:
mode:
authorRonnie Sahlberg <lsahlber@redhat.com>2021-01-20 23:22:48 +0100
committerSteve French <stfrench@microsoft.com>2021-01-23 08:28:20 +0100
commit214a5ea081e77346e4963dd6d20c5539ff8b6ae6 (patch)
tree52c616384ee424d55838edf0cece6a918f0d3280 /fs/cifs/fs_context.c
parentfs/cifs: Simplify bool comparison. (diff)
downloadlinux-214a5ea081e77346e4963dd6d20c5539ff8b6ae6.tar.xz
linux-214a5ea081e77346e4963dd6d20c5539ff8b6ae6.zip
cifs: do not fail __smb_send_rqst if non-fatal signals are pending
RHBZ 1848178 The original intent of returning an error in this function in the patch: "CIFS: Mask off signals when sending SMB packets" was to avoid interrupting packet send in the middle of sending the data (and thus breaking an SMB connection), but we also don't want to fail the request for non-fatal signals even before we have had a chance to try to send it (the reported problem could be reproduced e.g. by exiting a child process when the parent process was in the midst of calling futimens to update a file's timestamps). In addition, since the signal may remain pending when we enter the sending loop, we may end up not sending the whole packet before TCP buffers become full. In this case the code returns -EINTR but what we need here is to return -ERESTARTSYS instead to allow system calls to be restarted. Fixes: b30c74c73c78 ("CIFS: Mask off signals when sending SMB packets") Cc: stable@vger.kernel.org # v5.1+ Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com> Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com> Signed-off-by: Steve French <stfrench@microsoft.com>
Diffstat (limited to 'fs/cifs/fs_context.c')
0 files changed, 0 insertions, 0 deletions