summaryrefslogtreecommitdiffstats
path: root/fs/ext4/file.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2017-05-22 04:34:23 +0200
committerTheodore Ts'o <tytso@mit.edu>2017-05-22 04:34:23 +0200
commit3f1d5bad3fae983da07be01cff2fde13293bb7b9 (patch)
tree9cf8ce4c6c0b270949914a01445039f8ccd81eb7 /fs/ext4/file.c
parentext4: fix SEEK_HOLE (diff)
downloadlinux-3f1d5bad3fae983da07be01cff2fde13293bb7b9.tar.xz
linux-3f1d5bad3fae983da07be01cff2fde13293bb7b9.zip
ext4: fix off-by-in in loop termination in ext4_find_unwritten_pgoff()
There is an off-by-one error in loop termination conditions in ext4_find_unwritten_pgoff() since 'end' may index a page beyond end of desired range if 'endoff' is page aligned. It doesn't have any visible effects but still it is good to fix it. Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Diffstat (limited to 'fs/ext4/file.c')
-rw-r--r--fs/ext4/file.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index bbea2dccd584..2b00bf84c05b 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -474,7 +474,7 @@ static int ext4_find_unwritten_pgoff(struct inode *inode,
endoff = (loff_t)end_blk << blkbits;
index = startoff >> PAGE_SHIFT;
- end = endoff >> PAGE_SHIFT;
+ end = (endoff - 1) >> PAGE_SHIFT;
pagevec_init(&pvec, 0);
do {