diff options
| author | Jeremy Cline <jcline@redhat.com> | 2018-08-02 06:03:40 +0200 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2018-08-02 06:03:40 +0200 |
| commit | 1a5d5e5d51e75a5bca67dadbcea8c841934b7b85 (patch) | |
| tree | 5e6473b8361d5d4e9bd9caae0c282dc0eeed35fc /fs/ext4/inode.c | |
| parent | ext4: check for NUL characters in extended attribute's name (diff) | |
| download | linux-1a5d5e5d51e75a5bca67dadbcea8c841934b7b85.tar.xz linux-1a5d5e5d51e75a5bca67dadbcea8c841934b7b85.zip | |
ext4: fix spectre gadget in ext4_mb_regular_allocator()
'ac->ac_g_ex.fe_len' is a user-controlled value which is used in the
derivation of 'ac->ac_2order'. 'ac->ac_2order', in turn, is used to
index arrays which makes it a potential spectre gadget. Fix this by
sanitizing the value assigned to 'ac->ac2_order'. This covers the
following accesses found with the help of smatch:
* fs/ext4/mballoc.c:1896 ext4_mb_simple_scan_group() warn: potential
spectre issue 'grp->bb_counters' [w] (local cap)
* fs/ext4/mballoc.c:445 mb_find_buddy() warn: potential spectre issue
'EXT4_SB(e4b->bd_sb)->s_mb_offsets' [r] (local cap)
* fs/ext4/mballoc.c:446 mb_find_buddy() warn: potential spectre issue
'EXT4_SB(e4b->bd_sb)->s_mb_maxs' [r] (local cap)
Suggested-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Jeremy Cline <jcline@redhat.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@vger.kernel.org
Diffstat (limited to 'fs/ext4/inode.c')
0 files changed, 0 insertions, 0 deletions