diff options
| author | Darrick J. Wong <darrick.wong@oracle.com> | 2017-08-19 03:08:25 +0200 |
|---|---|---|
| committer | Darrick J. Wong <darrick.wong@oracle.com> | 2017-09-01 19:55:30 +0200 |
| commit | 799ea9e9c59949008770aab4e1da87f10e99dbe4 (patch) | |
| tree | a61a76330a6c6a1a45139df2afa9d2b4b2aee6fa /fs/internal.h | |
| parent | xfs: stop searching for free slots in an inode chunk when there are none (diff) | |
| download | linux-799ea9e9c59949008770aab4e1da87f10e99dbe4.tar.xz linux-799ea9e9c59949008770aab4e1da87f10e99dbe4.zip | |
xfs: evict all inodes involved with log redo item
When we introduced the bmap redo log items, we set MS_ACTIVE on the
mountpoint and XFS_IRECOVERY on the inode to prevent unlinked inodes
from being truncated prematurely during log recovery. This also had the
effect of putting linked inodes on the lru instead of evicting them.
Unfortunately, we neglected to find all those unreferenced lru inodes
and evict them after finishing log recovery, which means that we leak
them if anything goes wrong in the rest of xfs_mountfs, because the lru
is only cleaned out on unmount.
Therefore, evict unreferenced inodes in the lru list immediately
after clearing MS_ACTIVE.
Fixes: 17c12bcd30 ("xfs: when replaying bmap operations, don't let unlinked inodes get reaped")
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Cc: viro@ZenIV.linux.org.uk
Reviewed-by: Brian Foster <bfoster@redhat.com>
Diffstat (limited to 'fs/internal.h')
| -rw-r--r-- | fs/internal.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/internal.h b/fs/internal.h index 9676fe11c093..fedfe94d84ba 100644 --- a/fs/internal.h +++ b/fs/internal.h @@ -132,7 +132,6 @@ static inline bool atime_needs_update_rcu(const struct path *path, extern void inode_io_list_del(struct inode *inode); extern long get_nr_dirty_inodes(void); -extern void evict_inodes(struct super_block *); extern int invalidate_inodes(struct super_block *, bool); /* |