diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2024-02-17 21:23:54 +0100 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2024-02-21 09:34:25 +0100 |
| commit | ecba88a3b32d733d41e27973e25b2bc580f64281 (patch) | |
| tree | 65716b32a5b06d470298c4feb6de154dbd278f50 /fs/libfs.c | |
| parent | libfs: Define a minimum directory offset (diff) | |
| download | linux-ecba88a3b32d733d41e27973e25b2bc580f64281.tar.xz linux-ecba88a3b32d733d41e27973e25b2bc580f64281.zip | |
libfs: Add simple_offset_empty()
For simple filesystems that use directory offset mapping, rely
strictly on the directory offset map to tell when a directory has
no children.
After this patch is applied, the emptiness test holds only the RCU
read lock when the directory being tested has no children.
In addition, this adds another layer of confirmation that
simple_offset_add/remove() are working as expected.
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Link: https://lore.kernel.org/r/170820143463.6328.7872919188371286951.stgit@91.116.238.104.host.secureserver.net
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/libfs.c')
| -rw-r--r-- | fs/libfs.c | 32 |
1 files changed, 32 insertions, 0 deletions
diff --git a/fs/libfs.c b/fs/libfs.c index f0045db739df..f7f92a49a418 100644 --- a/fs/libfs.c +++ b/fs/libfs.c @@ -314,6 +314,38 @@ void simple_offset_remove(struct offset_ctx *octx, struct dentry *dentry) } /** + * simple_offset_empty - Check if a dentry can be unlinked + * @dentry: dentry to be tested + * + * Returns 0 if @dentry is a non-empty directory; otherwise returns 1. + */ +int simple_offset_empty(struct dentry *dentry) +{ + struct inode *inode = d_inode(dentry); + struct offset_ctx *octx; + struct dentry *child; + unsigned long index; + int ret = 1; + + if (!inode || !S_ISDIR(inode->i_mode)) + return ret; + + index = DIR_OFFSET_MIN; + octx = inode->i_op->get_offset_ctx(inode); + xa_for_each(&octx->xa, index, child) { + spin_lock(&child->d_lock); + if (simple_positive(child)) { + spin_unlock(&child->d_lock); + ret = 0; + break; + } + spin_unlock(&child->d_lock); + } + + return ret; +} + +/** * simple_offset_rename_exchange - exchange rename with directory offsets * @old_dir: parent of dentry being moved * @old_dentry: dentry being moved |