summaryrefslogtreecommitdiffstats
path: root/fs/nfs/nfs4state.c
diff options
context:
space:
mode:
authorChuck Lever <chuck.lever@oracle.com>2012-09-14 23:23:23 +0200
committerTrond Myklebust <Trond.Myklebust@netapp.com>2012-10-02 00:31:51 +0200
commitffe5a83005b0d23575ab109755b4cb5518a5d91f (patch)
treebe0a3c83446995a129f040c3bcb7c94b806b768c /fs/nfs/nfs4state.c
parentNFS: nfs_parsed_mount_options can use unsigned int (diff)
downloadlinux-ffe5a83005b0d23575ab109755b4cb5518a5d91f.tar.xz
linux-ffe5a83005b0d23575ab109755b4cb5518a5d91f.zip
NFS: Slow down state manager after an unhandled error
If the state manager thread is not actually able to fully recover from some situation, it wakes up waiters, who kick off a new state manager thread. Quite often the fresh invocation of the state manager is just as successful. This results in a livelock as the client dumps thousands of NFS requests a second on the network in a vain attempt to recover. Not very friendly. To mitigate this situation, add a delay in the state manager after an unhandled error, so that the client sends just a few requests every second in this case. Signed-off-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs/nfs/nfs4state.c')
-rw-r--r--fs/nfs/nfs4state.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index bd8ed01cb0ea..38eeefd95375 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -2015,6 +2015,7 @@ out_error:
pr_warn_ratelimited("NFS: state manager%s%s failed on NFSv4 server %s"
" with error %d\n", section_sep, section,
clp->cl_hostname, -status);
+ ssleep(1);
nfs4_end_drain_session(clp);
nfs4_clear_state_manager_bit(clp);
}