diff options
| author | Martin Brandenburg <martin@omnibond.com> | 2016-01-28 16:19:40 +0100 |
|---|---|---|
| committer | Mike Marshall <hubcap@omnibond.com> | 2016-01-28 21:08:40 +0100 |
| commit | 99109822f5cbe6d530eb55193b25aa5348f6134d (patch) | |
| tree | 5545d59702d9c2c2a28af01849a35f380ce01980 /fs/orangefs/inode.c | |
| parent | orangefs: Util functions shouldn't operate on inode where it can be avoided. (diff) | |
| download | linux-99109822f5cbe6d530eb55193b25aa5348f6134d.tar.xz linux-99109822f5cbe6d530eb55193b25aa5348f6134d.zip | |
orangefs: Fix revalidate.
Previously, it would update a live inode. This was fixed, but it did not
ever check that the inode attributes in the dcache are correct. This
checks all inode attributes and rejects any that are not correct, which
causes a lookup and thus a new getattr.
Perhaps inode_operations->permission should replace or augment some of
this.
There is no actual caching, and this does a rather excessive amount of
network operations back to the filesystem server.
Signed-off-by: Martin Brandenburg <martin@omnibond.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
Diffstat (limited to 'fs/orangefs/inode.c')
| -rw-r--r-- | fs/orangefs/inode.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c index 4724c92b61ac..040cd95b51c2 100644 --- a/fs/orangefs/inode.c +++ b/fs/orangefs/inode.c @@ -273,7 +273,7 @@ int orangefs_getattr(struct vfsmount *mnt, * fields/attributes of the inode would be refreshed. So again, we * dont have too much of a choice but refresh all the attributes. */ - ret = orangefs_inode_getattr(inode, ORANGEFS_ATTR_SYS_ALL_NOHINT); + ret = orangefs_inode_getattr(inode, ORANGEFS_ATTR_SYS_ALL_NOHINT, 0); if (ret == 0) { generic_fillattr(inode, kstat); /* override block size reported to stat */ @@ -392,7 +392,7 @@ struct inode *orangefs_iget(struct super_block *sb, struct orangefs_object_kref if (!inode || !(inode->i_state & I_NEW)) return inode; - error = orangefs_inode_getattr(inode, ORANGEFS_ATTR_SYS_ALL_NOHINT); + error = orangefs_inode_getattr(inode, ORANGEFS_ATTR_SYS_ALL_NOHINT, 0); if (error) { iget_failed(inode); return ERR_PTR(error); @@ -437,7 +437,7 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir, orangefs_set_inode(inode, ref); inode->i_ino = hash; /* needed for stat etc */ - error = orangefs_inode_getattr(inode, ORANGEFS_ATTR_SYS_ALL_NOHINT); + error = orangefs_inode_getattr(inode, ORANGEFS_ATTR_SYS_ALL_NOHINT, 0); if (error) goto out_iput; |