diff options
author | Darrick J. Wong <djwong@kernel.org> | 2023-12-15 19:03:45 +0100 |
---|---|---|
committer | Darrick J. Wong <djwong@kernel.org> | 2023-12-15 19:03:45 +0100 |
commit | 21d7500929c8a0b10e22a6755850c6f9a9280284 (patch) | |
tree | 35c571883e7554258ec8f2069ce689f0e02f34af /fs/xfs/Makefile | |
parent | xfs: check dquot resource timers (diff) | |
download | linux-21d7500929c8a0b10e22a6755850c6f9a9280284.tar.xz linux-21d7500929c8a0b10e22a6755850c6f9a9280284.zip |
xfs: improve dquot iteration for scrub
Upon a closer inspection of the quota record scrubber, I noticed that
dqiterate wasn't actually walking all possible dquots for the mapped
blocks in the quota file. This is due to xfs_qm_dqget_next skipping all
XFS_IS_DQUOT_UNINITIALIZED dquots.
For a fsck program, we really want to look at all the dquots, even if
all counters and limits in the dquot record are zero. Rewrite the
implementation to do this, as well as switching to an iterator paradigm
to reduce the number of indirect calls.
This enables removal of the old broken dqiterate code from xfs_dquot.c.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/Makefile')
-rw-r--r-- | fs/xfs/Makefile | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile index e7727451d1c8..cdf81eb180e2 100644 --- a/fs/xfs/Makefile +++ b/fs/xfs/Makefile @@ -176,7 +176,10 @@ xfs-$(CONFIG_XFS_RT) += $(addprefix scrub/, \ rtsummary.o \ ) -xfs-$(CONFIG_XFS_QUOTA) += scrub/quota.o +xfs-$(CONFIG_XFS_QUOTA) += $(addprefix scrub/, \ + dqiterate.o \ + quota.o \ + ) # online repair ifeq ($(CONFIG_XFS_ONLINE_REPAIR),y) |