diff options
| author | Qu Wenruo <wqu@suse.com> | 2024-01-09 23:28:26 +0100 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2024-01-12 02:04:19 +0100 |
| commit | 173431b274a9a54fc10b273b46e67f46bcf62d2e (patch) | |
| tree | 8d7927d102469a50d9f468ac2a31da8a3b2a1529 /fs | |
| parent | btrfs: avoid copying BTRFS_ROOT_SUBVOL_DEAD flag to snapshot of subvolume bei... (diff) | |
| download | linux-173431b274a9a54fc10b273b46e67f46bcf62d2e.tar.xz linux-173431b274a9a54fc10b273b46e67f46bcf62d2e.zip | |
btrfs: defrag: reject unknown flags of btrfs_ioctl_defrag_range_args
Add extra sanity check for btrfs_ioctl_defrag_range_args::flags.
This is not really to enhance fuzzing tests, but as a preparation for
future expansion on btrfs_ioctl_defrag_range_args.
In the future we're going to add new members, allowing more fine tuning
for btrfs defrag. Without the -ENONOTSUPP error, there would be no way
to detect if the kernel supports those new defrag features.
CC: stable@vger.kernel.org # 4.14+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/ioctl.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index fea5d37528b8..5d42319b43f2 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -2602,6 +2602,10 @@ static int btrfs_ioctl_defrag(struct file *file, void __user *argp) ret = -EFAULT; goto out; } + if (range.flags & ~BTRFS_DEFRAG_RANGE_FLAGS_SUPP) { + ret = -EOPNOTSUPP; + goto out; + } /* compression requires us to start the IO */ if ((range.flags & BTRFS_DEFRAG_RANGE_COMPRESS)) { range.flags |= BTRFS_DEFRAG_RANGE_START_IO; |