diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2007-10-26 19:33:01 +0200 |
|---|---|---|
| committer | Trond Myklebust <Trond.Myklebust@netapp.com> | 2008-01-30 08:05:46 +0100 |
| commit | 5cce428d953cc3843b100e078dbc3c01c6411b85 (patch) | |
| tree | 29a61ee7ae3dff46c240cd7c45ed22aa69c44064 /fs | |
| parent | NFS: Clean up address comparison in __nfs_find_client() (diff) | |
| download | linux-5cce428d953cc3843b100e078dbc3c01c6411b85.tar.xz linux-5cce428d953cc3843b100e078dbc3c01c6411b85.zip | |
NFS: Remove an unneeded check in decode_compound_header_arg()
Clean up: The header tag length is unsigned, so checking that it is less
than zero is unnecessary.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/callback_xdr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/callback_xdr.c b/fs/nfs/callback_xdr.c index 058ade7efe79..97abd829e432 100644 --- a/fs/nfs/callback_xdr.c +++ b/fs/nfs/callback_xdr.c @@ -139,7 +139,7 @@ static __be32 decode_compound_hdr_arg(struct xdr_stream *xdr, struct cb_compound if (unlikely(status != 0)) return status; /* We do not like overly long tags! */ - if (hdr->taglen > CB_OP_TAGLEN_MAXSZ-12 || hdr->taglen < 0) { + if (hdr->taglen > CB_OP_TAGLEN_MAXSZ - 12) { printk("NFSv4 CALLBACK %s: client sent tag of length %u\n", __FUNCTION__, hdr->taglen); return htonl(NFS4ERR_RESOURCE); |