diff options
| author | Andreas Gruenbacher <agruenba@redhat.com> | 2023-09-01 21:39:26 +0200 |
|---|---|---|
| committer | Andreas Gruenbacher <agruenba@redhat.com> | 2023-09-18 23:13:21 +0200 |
| commit | bbacb395ac5c57290cdfd02389788cbce64c237e (patch) | |
| tree | f21a312fc8497ee63a0f9246e189bdad30ab34a2 /fs | |
| parent | gfs2: Simplify function gfs2_upgrade_iopen_glock (diff) | |
| download | linux-bbacb395ac5c57290cdfd02389788cbce64c237e.tar.xz linux-bbacb395ac5c57290cdfd02389788cbce64c237e.zip | |
gfs2: Remove freeze_go_demote_ok
Before commit b77b4a4815a9 ("gfs2: Rework freeze / thaw logic"), the
freeze glock was kept around in the glock cache in shared mode without
being actively held while a filesystem is in thawed state. In that
state, memory pressure could have eventually evicted the freeze glock,
and the freeze_go_demote_ok callback was needed to prevent that from
happening.
With the freeze / thaw rework, the freeze glock is now always actively
held in shared mode while a filesystem is thawed, and the
freeze_go_demote_ok hack is no longer needed.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/gfs2/glops.c | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c index f41ca89d216b..5f845fd9f13a 100644 --- a/fs/gfs2/glops.c +++ b/fs/gfs2/glops.c @@ -614,18 +614,6 @@ static int freeze_go_xmote_bh(struct gfs2_glock *gl) } /** - * freeze_go_demote_ok - * @gl: the glock - * - * Always returns 0 - */ - -static int freeze_go_demote_ok(const struct gfs2_glock *gl) -{ - return 0; -} - -/** * iopen_go_callback - schedule the dcache entry for the inode to be deleted * @gl: the glock * @remote: true if this came from a different cluster node @@ -744,7 +732,6 @@ const struct gfs2_glock_operations gfs2_rgrp_glops = { const struct gfs2_glock_operations gfs2_freeze_glops = { .go_xmote_bh = freeze_go_xmote_bh, - .go_demote_ok = freeze_go_demote_ok, .go_callback = freeze_go_callback, .go_type = LM_TYPE_NONDISK, .go_flags = GLOF_NONDISK, |