diff options
| author | Philipp Stanner <pstanner@redhat.com> | 2024-10-23 16:15:31 +0200 |
|---|---|---|
| committer | Philipp Stanner <pstanner@redhat.com> | 2024-10-25 18:02:04 +0200 |
| commit | 3ae80b375739495e36fc6143ff27716fe390a13e (patch) | |
| tree | 53c20f4d0948f48ac76b896fe51a81bfccc5a3c0 /include/drm | |
| parent | drm/panfrost: Remove unused id_mask from struct panfrost_model (diff) | |
| download | linux-3ae80b375739495e36fc6143ff27716fe390a13e.tar.xz linux-3ae80b375739495e36fc6143ff27716fe390a13e.zip | |
drm/sched: warn about drm_sched_job_init()'s partial init
drm_sched_job_init()'s name suggests that after the function succeeded,
parameter "job" will be fully initialized. This is not the case; some
members are only later set, notably drm_sched_job.sched by
drm_sched_job_arm().
Document that drm_sched_job_init() does not set all struct members.
Document the lifetime of drm_sched_job.sched.
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241023141530.113370-2-pstanner@redhat.com
Diffstat (limited to 'include/drm')
| -rw-r--r-- | include/drm/gpu_scheduler.h | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/include/drm/gpu_scheduler.h b/include/drm/gpu_scheduler.h index ab161289d1bf..95e17504e46a 100644 --- a/include/drm/gpu_scheduler.h +++ b/include/drm/gpu_scheduler.h @@ -340,6 +340,14 @@ struct drm_sched_fence *to_drm_sched_fence(struct dma_fence *f); struct drm_sched_job { struct spsc_node queue_node; struct list_head list; + + /** + * @sched: + * + * The scheduler this job is or will be scheduled on. Gets set by + * drm_sched_job_arm(). Valid until drm_sched_backend_ops.free_job() + * has finished. + */ struct drm_gpu_scheduler *sched; struct drm_sched_fence *s_fence; |