diff options
| author | Eric Anholt <eric@anholt.net> | 2016-10-21 01:48:12 +0200 |
|---|---|---|
| committer | Eric Anholt <eric@anholt.net> | 2016-11-04 02:48:07 +0100 |
| commit | 457e67a728696c4f8e6423c64e93def50530db9a (patch) | |
| tree | 920dd427cce4eb6fd9584051745e8a57ae98c3cc /include | |
| parent | drm/vc4: Fix a couple error codes in vc4_cl_lookup_bos() (diff) | |
| download | linux-457e67a728696c4f8e6423c64e93def50530db9a.tar.xz linux-457e67a728696c4f8e6423c64e93def50530db9a.zip | |
drm/vc4: Fix termination of the initial scan for branch targets.
The loop is scanning until the original max_ip (size of the BO), but
we want to not examine any code after the PROG_END's delay slots.
There was a block trying to do that, except that we had some early
continue statements if the signal wasn't a PROG_END or a BRANCH.
The failure mode would be that a valid shader is rejected because some
undefined memory after the PROG_END slots is parsed as a branch and
the rest of its setup is illegal. I haven't seen this in the wild,
but valgrind was complaining when about this up in the userland
simulator mode.
Signed-off-by: Eric Anholt <eric@anholt.net>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions