diff options
| author | Benjamin Tissoires <bentiss@kernel.org> | 2024-07-08 11:52:57 +0200 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2024-07-08 19:01:48 +0200 |
| commit | f56f4d541eab1ae060a46b56dd6ec9130d6e3a98 (patch) | |
| tree | d4597e7a4336c3472ef18a6ca6c6ef1eb7995328 /kernel/bpf | |
| parent | libbpf: Add NULL checks to bpf_object__{prev_map,next_map} (diff) | |
| download | linux-f56f4d541eab1ae060a46b56dd6ec9130d6e3a98.tar.xz linux-f56f4d541eab1ae060a46b56dd6ec9130d6e3a98.zip | |
bpf: helpers: fix bpf_wq_set_callback_impl signature
I realized this while having a map containing both a struct bpf_timer and
a struct bpf_wq: the third argument provided to the bpf_wq callback is
not the struct bpf_wq pointer itself, but the pointer to the value in
the map.
Which means that the users need to double cast the provided "value" as
this is not a struct bpf_wq *.
This is a change of API, but there doesn't seem to be much users of bpf_wq
right now, so we should be able to go with this right now.
Fixes: 81f1d7a583fa ("bpf: wq: add bpf_wq_set_callback_impl")
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
Link: https://lore.kernel.org/r/20240708-fix-wq-v2-1-667e5c9fbd99@kernel.org
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Diffstat (limited to 'kernel/bpf')
| -rw-r--r-- | kernel/bpf/helpers.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 229396172026..5241ba671c5a 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c @@ -2734,7 +2734,7 @@ __bpf_kfunc int bpf_wq_start(struct bpf_wq *wq, unsigned int flags) } __bpf_kfunc int bpf_wq_set_callback_impl(struct bpf_wq *wq, - int (callback_fn)(void *map, int *key, struct bpf_wq *wq), + int (callback_fn)(void *map, int *key, void *value), unsigned int flags, void *aux__ign) { |