diff options
| author | Zqiang <qiang.zhang@windriver.com> | 2021-02-18 04:16:49 +0100 |
|---|---|---|
| committer | Tejun Heo <tj@kernel.org> | 2021-04-04 19:26:46 +0200 |
| commit | 0687c66b5f666b5ad433f4e94251590d9bc9d10e (patch) | |
| tree | 2518008cd800c0073c604a540ebaf7dd4485a5df /kernel/workqueue.c | |
| parent | Merge tag 'for-linus' of git://github.com/openrisc/linux (diff) | |
| download | linux-0687c66b5f666b5ad433f4e94251590d9bc9d10e.tar.xz linux-0687c66b5f666b5ad433f4e94251590d9bc9d10e.zip | |
workqueue: Move the position of debug_work_activate() in __queue_work()
The debug_work_activate() is called on the premise that
the work can be inserted, because if wq be in WQ_DRAINING
status, insert work may be failed.
Fixes: e41e704bc4f4 ("workqueue: improve destroy_workqueue() debuggability")
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Reviewed-by: Lai Jiangshan <jiangshanlai@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 0d150da252e8..21fb00b52def 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1412,7 +1412,6 @@ static void __queue_work(int cpu, struct workqueue_struct *wq, */ lockdep_assert_irqs_disabled(); - debug_work_activate(work); /* if draining, only works from the same workqueue are allowed */ if (unlikely(wq->flags & __WQ_DRAINING) && @@ -1494,6 +1493,7 @@ retry: worklist = &pwq->delayed_works; } + debug_work_activate(work); insert_work(pwq, work, worklist, work_flags); out: |